Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some rules are missing a category tag #2554

Closed
WilcoFiers opened this issue Oct 13, 2020 · 2 comments
Closed

Some rules are missing a category tag #2554

WilcoFiers opened this issue Oct 13, 2020 · 2 comments
Assignees
@straker
Labels
fix Bug fixes hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ rule metadata Issues in the rule metadata code (lib/rules)
Milestone
axe-core 4.1

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Oct 13, 2020 •
edited
Loading

Expectation: All rules have a category (cat:*) tag

Actual: Some rules, such as aria-toggle-field-name do not

The easiest place to see missing tags is to look at the docs/rule-description.md file. In addition to adding these tags, we should add a test to build/tasks/validate.js to enforce that all rules have a category tag.
@WilcoFiers WilcoFiers added fix Bug fixes rule metadata Issues in the rule metadata code (lib/rules) labels Oct 13, 2020
@WilcoFiers WilcoFiers added this to the axe-core 4.1 milestone Oct 13, 2020
@WilcoFiers WilcoFiers added the hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ label Oct 13, 2020
@mDalessandro
Copy link
Contributor

I can take a look at this.

@mDalessandro mDalessandro mentioned this issue Oct 20, 2020
Merged
2 tasks
@straker straker self-assigned this Oct 20, 2020
WilcoFiers added a commit that referenced this issue Oct 21, 2020
@mDalessandro @WilcoFiers
fix(docs/rules): add missing category tags to rules metadata (#2569)
285c442 
Add category tags to the rules that were missing them.
Add validation to check during a build for the inclusion of a category on the rule metadata.

Closes issue #2554

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@padmavemulapati
Copy link

Verified in the latest axe-core latest develop ,
Added category - tag for the following rules/ids

aria-input-field-name: cat.aria
aria-toggle-field-name: cat.aria
aria-tooltip-name: cat.aria
avoid-inline-spacing: cat.structure
identical-links-same-purpose: cat.semantics
label-content-name-mismatch: cat.semantics
no-autoplay-audio: cat.time-and-media
scrollable-region-focusable: cat.keyboard
accesskeys: cat.keyboard

@straker straker closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@straker straker

Labels
fix Bug fixes hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Milestone
axe-core 4.1
Development

No branches or pull requests
4 participants
@WilcoFiers @straker @mDalessandro @padmavemulapati