New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast): properly handle scrolling text #2619

Merged

straker merged 2 commits into develop from color-contrast-rect-width

Nov 3, 2020

Contributor

straker commented Nov 2, 2020 •

edited by WilcoFiers

Loading

Text whose container was smaller than the text itself caused the same problems as truncated text.

Closes issue: #2483

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

Follows the commit message policy, appropriate for next version
Code is reviewed for security


          fix(color-contrast): properly handle scrolling text

cbb22da

straker requested a review from a team as a code owner

November 2, 2020 22:56


          fix tests

1ddf0a2

WilcoFiers approved these changes

View reviewed changes

straker merged commit 984e7e2 into develop

straker deleted the color-contrast-rect-width branch

November 3, 2020 15:13

WilcoFiers mentioned this pull request

Runtime issue: TypeError: Cannot read property 'filter' of undefined #2516

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet