Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group should be an allowable requiredContext for menuitemcheckbox as of ARIA 1.2 #2736

Closed
dbjorge opened this issue Jan 7, 2021 · 1 comment
Labels
info needed More information or research is needed to continue

Comments

@dbjorge
Copy link
Contributor

dbjorge commented Jan 7, 2021

Expectation: As of ARIA 1.2 (specifically, PR w3c/aria#737), group has become an acceptable required context role for the menuitemcheckbox role; axe-core should recognize this now that it's picking up other ARIA 1.2 role relationship updates.

Actual: lib/standards/aria-roles.js hasn't been updated to account for that yet, so axe 4.1.1 still reports an aria-required-parent failure for the button in this snippet (codepen):

<div role="group">
  <button role="menuitemcheckbox">test element</button>
</div>

Motivation: false positive in aria-required-parent rule


axe-core version: 4.1.1
axe-webdriver, extension or other integration version: accessibility insights for web 0.23.0

Browser and Assistive Technology versions: Microsoft Edge stable (Version 87.0.664.66 (Official build) (64-bit)), no AT in use
@straker
Copy link
Contributor

straker commented Jan 13, 2021

We've been having some discussion of this in the PR that was opened for it. There's some issues this causes for screen reader so we're determining what should happen.

@straker straker closed this as completed in e0d30e5 Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info needed More information or research is needed to continue
Projects
None yet
Development

No branches or pull requests

2 participants