Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow menuitemcheckbox to have a group parent like menuitemradio and menutiem do when in a menu role #737

Closed
jnurthen opened this issue May 7, 2018 · 0 comments
Closed

Allow menuitemcheckbox to have a group parent like menuitemradio and menutiem do when in a menu role #737

jnurthen opened this issue May 7, 2018 · 0 comments
Labels
has PR PR exists that will close this issue merged to stable
Milestone
ARIA 1.2

Comments

@jnurthen
Copy link
Member

jnurthen commented May 7, 2018

https://www.w3.org/WAI/ARIA/track/issues/501
jnurthen added a commit that referenced this issue Jun 21, 2018
@jnurthen
Issue #737
211b5ed 
* resolve inconsistencies around menuitems being allowed in groups
* allow menuitemcheckbox to be in a group.
@mcking65 mcking65 mentioned this issue Jul 12, 2018
Open
jnurthen added a commit that referenced this issue Jul 12, 2018
@jnurthen
Issue737 menuitem and groups (#784)
d02bba9 
* Issue #737
* resolve inconsistencies around menuitems being allowed in groups
* allow menuitemcheckbox to be in a group.
@mcking65 mcking65 mentioned this issue Oct 1, 2018
Closed
@jnurthen jnurthen added this to the ARIA 1.2 milestone Sep 27, 2019
@jnurthen jnurthen added has PR PR exists that will close this issue merged to stable labels Oct 3, 2019
jnurthen added a commit that referenced this issue Oct 23, 2019
@jnurthen
Issue737 menuitem and groups (#784)
639d704 
* Issue #737
* resolve inconsistencies around menuitems being allowed in groups
* allow menuitemcheckbox to be in a group.
@dbjorge dbjorge mentioned this issue Jan 7, 2021
Closed
@smockle smockle mentioned this issue Jan 7, 2021
Merged
straker pushed a commit to dequelabs/axe-core that referenced this issue Feb 9, 2021
@smockle
Allow 'menuitem' and 'menuitemcheckbox' to be in a 'group', per ARIA …
e0d30e5 
…1.2 (#2737)

* Allow 'menuitem' and 'menuitemcheckbox' to be in a 'group', per ARIA 1.2

Fixes: #2736
Spec issue: w3c/aria#737
Spec PR: w3c/aria#784

* tests: Add happy and sad path tests for role=group

* feat: Make 'getMissingContext' check 'group'’s parent’s role

* fix: Test 'role=group' is disallowed

* fix: Only permit role=group when it’s an allowed context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has PR PR exists that will close this issue merged to stable
Projects
None yet
Milestone
ARIA 1.2
Development

No branches or pull requests
1 participant
@jnurthen