fix(required-parent): Allow *item > group > *item nesting #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
force-pushed
the
group-treeitem-fix
branch
from
bed8b5e
to
1990875
Compare
WilcoFiers
force-pushed
the
group-treeitem-fix
branch
from
1990875
to
2996146
Compare
WilcoFiers
commented
Apr 30, 2021
| try { | ||
| var test = JSON.parse(content); | ||
| } catch (e) { | ||
| throw new Error('Unable to parse content of ' + file.originalPath) |
There was a problem hiding this comment.
Encountered this because I had a stray comma. Figured I'd tweak it a bit.
| @@ -107,6 +108,29 @@ All checks allow these global options: | |||
| </tbody> | |||
| </table> | |||
|
|
|||
| ### aria-required-parent | |||
|
|
|||
| <table> | |||
There was a problem hiding this comment.
NBD but it's strange that we're not using Markdown to generate this table 🤷
There was a problem hiding this comment.
I remember it was because Markdown table syntax wasn't working so well with multiline code blocks in the cells.
straker
approved these changes
Apr 30, 2021
straker
pushed a commit
that referenced
this pull request
May 18, 2021
* fix(required-parent): Allow *item > group > *item nesting * chore(required-parent): Exclude menuitem from exception * chore(required-parent): Add ownGroupRoles option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2897.
Need to look into menuitem before we merge this.
menuitem > group > menuitemdoesn't work nearly as well as treeitem and listitem seem to.