Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor unsupportedrole check bugs #3282

Closed
WilcoFiers opened this issue Nov 12, 2021 · 1 comment
Closed

Minor unsupportedrole check bugs #3282

WilcoFiers opened this issue Nov 12, 2021 · 1 comment
Labels
fix Bug fixes good first issue For first-time contributors tech debt Technical debt related tasks
Milestone
Axe-core 4.7

Comments

@WilcoFiers
Copy link
Contributor

I don't think this impacts anyone today, since there are currently no unsupported roles listed in axe-core. But I noticed the following bugs.

  • The value is not set, even though it's used in the fail message
  • dpub roles can not be listed as unsupported, because they are ignored by default in getRole
  • a role attribute using a fallback roles will not recognise the unsupported role, even if it's the first (role="unsupported button")

We can easily solve this by replicating what we did in the deprecatedrole check.
@WilcoFiers WilcoFiers added fix Bug fixes tech debt Technical debt related tasks good first issue For first-time contributors labels Nov 12, 2021
@WilcoFiers WilcoFiers added this to the Axe-core 4.5 milestone Nov 12, 2021
dan-tripp added a commit to dan-tripp/axe-core that referenced this issue Feb 21, 2022
@dan-tripp
fix(rules): unsupportedrole check bugs
717c3a8 
Closes issue dequelabs#3282
@dan-tripp dan-tripp mentioned this issue Feb 21, 2022
Merged
dan-tripp added a commit to dan-tripp/axe-core that referenced this issue Feb 27, 2022
@dan-tripp
fix(rules): unsupportedrole check bugs
e2ae194 
Closes issue dequelabs#3282
straker pushed a commit that referenced this issue Feb 28, 2022
@dan-tripp
fix(checks/unsupportedrole): support unsupported dpub and fallback ro…
3c0f10f 
…les, add role to message (#3395)

* refactor(checks/navigation): improve `internal-link-present-evaluate`

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue #2466

* test commit 1

* test commit 2

* test commit 3

* Revert "Merge branch 'dan-test-branch-1' into develop"

This reverts commit 428e015, reversing
changes made to 9f996bc.

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* test commit 1

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue #2934

* work in progress

* work in progress

* fix whitespace

* add new case to test test/checks/keyboard/no-focusable-content.js

* change "disabled" test case in test/checks/keyboard/no-focusable-content.js

* fix merge problem

* fix(rules): unsupportedrole check bugs

Closes issue #3282

* lint fix

* add assertion on checkContext._data to unit tests

* refactor(checks/unsupportedrole): change this.data from using array to single string

to match lib/checks/aria/deprecatedrole-evaluate.js

* Revert "refactor(checks/unsupportedrole): change this.data from using array to single string"

This reverts commit e7c757f9330b635b1ed16385b3526f2e71786488.

* refactor(checks/unsupportedrole): change this.data from using array to single string
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.5, Axe-core 4.6 May 20, 2022
@WilcoFiers
Copy link
Contributor Author

This looks fixed.

@Shubhabrata08 Shubhabrata08 mentioned this issue Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Bug fixes good first issue For first-time contributors tech debt Technical debt related tasks
Projects
None yet
Milestone
Axe-core 4.7
Development

No branches or pull requests
1 participant
@WilcoFiers