a[href][disabled] is still a focusable element #3315
Labels
commons
Issues in the common code (lib/commons)
fix
Bug fixes
good first issue
For first-time contributors
pr
A pr has been created for the issue
Comments
WilcoFiers
added
fix
|
I would like to fix this one. But it might take me a few weeks to get around to it. |
|
@dan-tripp You are welcome to it. Much appreciated! |
dan-tripp
added a commit
to dan-tripp/axe-core
that referenced
this issue
Feb 12, 2022
Now checks "disabled" attribute Closes issue dequelabs#3315
dan-tripp
added a commit
to dan-tripp/axe-core
that referenced
this issue
Feb 21, 2022
Now checks "disabled" attribute Closes issue dequelabs#3315
straker
added a commit
that referenced
this issue
Feb 22, 2022
…s as disabled (#3393) * refactor(checks/navigation): improve `internal-link-present-evaluate` Make `internal-link-present-evaluate` work with virtualNode rather than actualNode. Closes issue #2466 * test commit 1 * test commit 2 * test commit 3 * Revert "Merge branch 'dan-test-branch-1' into develop" This reverts commit 428e015, reversing changes made to 9f996bc. * Revert "test commit 1" This reverts commit 9f996bc. * fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive" Closes issue #2934 * work in progress * work in progress * test commit 1 * Revert "test commit 1" This reverts commit 9f996bc. * fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive" Closes issue #2934 * work in progress * work in progress * fix whitespace * add new case to test test/checks/keyboard/no-focusable-content.js * change "disabled" test case in test/checks/keyboard/no-focusable-content.js * fix merge problem * fix(commons/dom): focusDisabled() behavior Now checks "disabled" attribute Closes issue #3315 * Update lib/commons/dom/focus-disabled.js Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * fix typo Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
|
I was looking for issues to fix and I noticed this issue was already fixed in bb8b5ca, could a maintainer mark this as closed? |
|
Verified with the latest dev branch code , role=text is allowing to have "tabindex=-1" as a descendants and with the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Noticed this in reviewing #3165. In determining if an element is focused, axe-core looks at the disabled attribute. However it doesn't check if that attribute is allowed for the node. So the following link is incorrectly determined as not focusable:
This bug exists in
lib/commons/dom/focus-disabled.js. The fix is to checkvNode.props.nodeNamebefore looking for thedisabledattribute.The text was updated successfully, but these errors were encountered: