fix(checks/unsupportedrole): support unsupported dpub and fallback roles, add role to message #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `internal-link-present-evaluate` work with virtualNode rather than actualNode. Closes issue dequelabs#2466
This reverts commit 9f996bc.
…ractive" Closes issue dequelabs#2934
…dequelabs-develop-2
Dequelabs develop 2
work in progress
work in progress
straker
requested changes
Feb 25, 2022
There was a problem hiding this comment.
Thanks for the pr. Overall it looks good, the only request I have is that we'll want to check the checkContext._data to ensure that the role is set (since we weren't setting it before).
So for tests that return true, we'll check that the role is set:
assert.deepEqual(checkContext._data, [role]);and for tests that return false, we'll want to check that it's null
assert.isNull(checkContext._data);See https://github.com/dequelabs/axe-core/blob/develop/test/checks/aria/deprecatedrole.js for examples of doing this.
Closes issue dequelabs#3282
…o single string to match lib/checks/aria/deprecatedrole-evaluate.js
… array to single string" This reverts commit e7c757f9330b635b1ed16385b3526f2e71786488.
|
That makes sense. I like axe-core's test philosophy. Does my latest push reflect what you have in mind? |
straker
approved these changes
Feb 28, 2022
straker
changed the title
|
Nice. Thanks again for the guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(rules): unsupportedrole check bugs
Closes issue #3282