Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make frame-title-unique a reviewOnly WCAG412 rule #3487

Closed
WilcoFiers opened this issue Jun 1, 2022 · 1 comment
Closed

Make frame-title-unique a reviewOnly WCAG412 rule #3487

WilcoFiers opened this issue Jun 1, 2022 · 1 comment
Assignees
@dbowling
Labels
ACT Rules good first issue For first-time contributors pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules)

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jun 1, 2022 •
edited
Loading

Aze-core's frame-title-unique rule is currently inconsistent with ACT Rules because it is far too strict. A better approach to this rule would be to change the tags, give it the wcag412 and wcag2a tags, and remove best-practice, then add "reviewOnFail": true to the rule so it never flags things as violations. We simply cannot tell these are WCAG violations. This makes the rule partially consistent with the Iframe elements with identical accessible names have equivalent purpose ACT rule.
@WilcoFiers WilcoFiers added rule metadata Issues in the rule metadata code (lib/rules) ACT Rules good first issue For first-time contributors labels Jun 1, 2022
dbowling added a commit that referenced this issue Aug 16, 2022
@dbowling
fix(frame-title-unique): Make frame-title-unique a reviewOnly WCAG412…
a5b1b23 
… rule

references: #3487
@dbowling dbowling mentioned this issue Aug 16, 2022
Merged
@dbowling dbowling added the pr A pr has been created for the issue label Aug 16, 2022
dbowling added a commit that referenced this issue Aug 24, 2022
@dbowling
fix(frame-title-unique): Make frame-title-unique reviewOnly and WCAG4…
8401b8e 
…12 (#3610)

* add tags: wcag412 and wcag2a
* remove tag: best-practice
* add "reviewOnFail": true
* fix edge case where reviewOnFail did not result in after function setting results properly

references: #3487
@padmavemulapati
Copy link

Validated in the latest develop branch code base,
frame-title-unique is showing in the incomplete results now and also having no best-practice tag value.
We are seeing only tags,

0: "cat.text-alternatives"
1: "wcag412"
2: "wcag2a"

image

Earlier this rule is in list of violations, and also having only best-practice tag

image

@Shubhabrata08 Shubhabrata08 mentioned this issue Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbowling dbowling

Labels
ACT Rules good first issue For first-time contributors pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbowling @WilcoFiers @padmavemulapati