Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have the aria-hidden-body rule map to 1.3.1 #4315

Closed
WilcoFiers opened this issue Jan 31, 2024 · 4 comments · Fixed by #4349 · May be fixed by wingn8t/wagtail#1, gurudeep9/mattermost-test#2 or abdulrahman305/docs#4
Closed

Have the aria-hidden-body rule map to 1.3.1 #4315

WilcoFiers opened this issue Jan 31, 2024 · 4 comments · Fixed by #4349 · May be fixed by wingn8t/wagtail#1, gurudeep9/mattermost-test#2 or abdulrahman305/docs#4
Assignees
@CBID2
Labels
feat New feature or enhancement good first issue For first-time contributors rule metadata Issues in the rule metadata code (lib/rules)
Milestone
Axe-core 4.9.0

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jan 31, 2024 •
edited by straker
Loading

The aria-hidden-body rule has the wcag412 tag, that's probably correct, but it might also be good to add wcag131 to the list. That's just as likely to be failed when aria-hidden-body finds a problem. This can be fixed by adding a tag to the aria-hidden-body rule.
@WilcoFiers WilcoFiers added feat New feature or enhancement rule metadata Issues in the rule metadata code (lib/rules) good first issue For first-time contributors labels Jan 31, 2024
@WilcoFiers WilcoFiers added this to the Axe-core 4.9 milestone Jan 31, 2024
@CBID2
Copy link
Contributor

CBID2 commented Feb 19, 2024

Can I be assigned to this? I’m new here! :)

@straker
Copy link
Contributor

straker commented Feb 20, 2024

@CBID2 Welcome and yep! Please let us know if you have any questions.

@CBID2
Copy link
Contributor

CBID2 commented Feb 21, 2024

@CBID2 Welcome and yep! Please let us know if you have any questions.

Hi @straker. I’m not sure where to make the changes in regards to files.

@straker
Copy link
Contributor

straker commented Feb 21, 2024 •
edited
Loading

Each rule can be found in the rules directory. In this case the change should happen in the aria-hidden-body rule and you'll want to update the tag array to include wcag131 (right before wcag412 as we have a particular order for the tags).

For this change we won't need to add any tests, so should just be the 1 file to update.

@CBID2 CBID2 mentioned this issue Feb 29, 2024
Merged
WilcoFiers added a commit that referenced this issue Mar 5, 2024
@CBID2 @WilcoFiers
feat: adding the wcag131 tag to the aria-hidden-body rule (#4349)
dd4c3c3 
<< Describe the changes >>
This PR adds the `wcag412` tag to the aria-hidden-body rule, making it
easier for the testing engine to detect issues.

Closes #4315

---------

Signed-off-by: Christine <shecoder30@gmail.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@attest-team-ci attest-team-ci mentioned this issue Mar 25, 2024
Merged
WilcoFiers added a commit that referenced this issue Mar 25, 2024
@WilcoFiers
chore(release): v4.9.0 (#4380)
d847924 
##
[4.9.0](v4.8.4...v4.9.0)
(2024-03-25)

### Features

- adding the wcag131 tag to the aria-hidden-body rule
([#4349](#4349))
([dd4c3c3](dd4c3c3)),
closes [#4315](#4315)
- **checks:** deprecate aria-busy check
([#4356](#4356))
([be0b555](be0b555)),
closes [#4347](#4347)
[#4340](#4340)
- **color:** add color channel values and luminosity, saturation, clip
functions ([#4366](#4366))
([9e70199](9e70199)),
closes
[/github.com//pull/4365/files#r1517706612](https://github.com/dequelabs//github.com/dequelabs/axe-core/pull/4365/files/issues/r1517706612)
- **i18n:** add Greek Translations
([#3836](#3836))
([3ea9a48](3ea9a48))
- **i18n:** Add Italian translation
([#4344](#4344))
([de1baa9](de1baa9))
- **i18n:** Add Simplified Chinese translation
([#4379](#4379))
([bda7c8d](bda7c8d))
- **i18n:** Add Taiwanese Mandarin translation
([#4299](#4299))
([c5e11de](c5e11de))

### Bug Fixes

- Add LICENSE-3RD-PARTY.txt file
([#4304](#4304))
([daa0fe6](daa0fe6))
- add Object.values polyfill for node <=6
([#4274](#4274))
([5eb867b](5eb867b))
- **aria-required-children:** avoid confusing aria-busy message in
failures ([#4347](#4347))
([591607d](591607d)),
closes [#fail13](https://github.com/dequelabs/axe-core/issues/fail13)
[#4340](#4340)
- avoid reading element-specific node properties of non-element node
types ([#4317](#4317))
([b853b18](b853b18)),
closes [#4316](#4316)
[#4316](#4316)
- **color-contrast:** handle text that is outside `overflow: hidden`
ancestor ([#4357](#4357))
([bdb7300](bdb7300)),
closes [#4253](#4253)
- **color-contrast:** support color blend modes hue, saturation, color,
luminosity ([#4365](#4365))
([7ae4761](7ae4761))
- **d.ts:** RawNodesResult issues
([#4229](#4229))
([d660518](d660518))
- **d.ts:** RunOptions.reporter can be any string
([#4218](#4218))
([e53f5c5](e53f5c5))
- **i18n:** update Italian translations
([#4377](#4377))
([4d65d4b](4d65d4b))
- **listitem:** clarify roleNotValid message
([#4374](#4374))
([0f8a9af](0f8a9af))
- **scrollable-region-focusable:** missing wcag213 tag
([#4201](#4201))
([0080a72](0080a72))
- **target-size:** always pass 10x targets (avoid perf bottleneck)
([#4376](#4376))
([be327c4](be327c4))
- **target-size:** do not crash for nodes with many overlapping widgets
([#4373](#4373))
([1dbea83](1dbea83)),
closes [#4359](#4359)
[#4359](#4359)
[#4360](#4360)
- **utils/get-selector:** ignore 'xmlns' attribute when generating a
selector ([#4303](#4303))
([938b411](938b411))

This PR was opened by a robot 🤖 🎉
@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Closed
@wingn8t wingn8t mentioned this issue Jun 14, 2024
Open
@gurudeep9 gurudeep9 mentioned this issue Jun 23, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this issue Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CBID2 CBID2

Labels
feat New feature or enhancement good first issue For first-time contributors rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Milestone
Axe-core 4.9.0
3 participants
@WilcoFiers @straker @CBID2