Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-accessible-name #470

Closed
WilcoFiers opened this issue Aug 3, 2017 · 10 comments
Closed

aria-accessible-name #470

WilcoFiers opened this issue Aug 3, 2017 · 10 comments
Labels
rules Issue or false result from an axe-core rule
Milestone

Comments

@WilcoFiers
Copy link
Contributor

Looks like [role="img"] isn't included in image rules but with the existent has-alt rule just ensure that the element is an IMG element.

We could do this either in a separate rule for role=img, or we can create a list of roles that in aria 1.1 are have "Accessible Name Required: True"

@WilcoFiers WilcoFiers added the rules Issue or false result from an axe-core rule label Aug 9, 2017
@WilcoFiers WilcoFiers changed the title Issue should be raised for [role="img"] element with no accessible name aria-accessible-name Nov 1, 2017
@WilcoFiers
Copy link
Contributor Author

We'll have to look to exclude elements already tested by other rules.

@Wildebrew
Copy link

In recent testing we discovered that Axe does not flag missing accessible name for a modal dialog.
According to the ARIA 1.1 spec entry for the dialog role an element with role="dialog" requires an accessible name (reference the accessible name reqruied entry in the characteristics table at the end of the role description entry).

My interpretation is that if an element requires an accessible name, not providing that name is a WCAG 4.1.2 fail, doesn't matter if the element is an ARIA dialog or an HTML link.

As much fun as WCAG interpretation gymnastics can be, the reason I am commenting is that we found that when a dialog is missing an accessible name,the screen reader experience degrades significantly.

I vote that this issue be addressed, not just for dialog but for any ARIA role where accessible name is required, or at least that the issue be discussed and a formal decision made.

@dylanb
Copy link
Contributor

dylanb commented Jun 15, 2019

This should be a best practice

@Wildebrew
Copy link

Wildebrew commented Jun 15, 2019 via email

@dylanb
Copy link
Contributor

dylanb commented Jun 15, 2019

@Wildebrew Thinking through the scenarios here:

  1. If the modal has a heading inside it, then the heading should be the accessible name but the fact that it has a heading that can be found means that it is not really creating an accessibility problem. Usability might be improved (also might be decreased) by adding it as a name through (for example) aria-labelledby (best practice would cover this)
  2. If the modal does not have a visible "name", then there is no missing information per se, so I don't know which WCAG S.C. this should fail
  3. If the modal's content is all in the form of non-text, then the non-text needs to have a text alternative - which will be caught by different checks

Are there other scenarios?

@Wildebrew
Copy link

Wildebrew commented Jun 16, 2019 via email

@honoka-h
Copy link
Contributor

My colleague and I have seen widgets (or parts of them) that do not have accessible names in the past (e.g. tabpanel in a tab). It would be very helpful if axe can report when widgets are missing required accessible names.

@WilcoFiers
Copy link
Contributor Author

Need to figure out which groups of elements we can test in a single rule. We'll probably need to have multiple rules for this. Part of this was already picked up in existing rules as well.

@WilcoFiers
Copy link
Contributor Author

We should probably look at ARIA 1.2 rather than 1.1, as some of the things that required an accessible name before don't do so anymore for 1.2:

https://www.w3.org/TR/wai-aria-1.2/

@WilcoFiers WilcoFiers added this to the Attest-Ruby v3.4 Release milestone Jul 29, 2019
@WilcoFiers WilcoFiers removed this from the Attest-Ruby v3.4 Release milestone Aug 27, 2019
@straker straker added this to the Axe-core 4.0 milestone Mar 30, 2020
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.0, axe-core 4.1 Apr 28, 2020
@WilcoFiers
Copy link
Contributor Author

Primary conversation for this is happening on #2421. I'm closing this as a duplicate.

mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

5 participants