Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when given an unknown ruleset tag or rule ID #82

Closed
jasonkarns opened this issue Jul 28, 2015 · 2 comments
Closed

Warn when given an unknown ruleset tag or rule ID #82

jasonkarns opened this issue Jul 28, 2015 · 2 comments
Labels
feat New feature or enhancement

Comments

@jasonkarns
Copy link
Contributor

a11yCheck({}, {
  runOnly: {
    type: "tag",
    values: ["my-made-up-tag"]
  }
})

I would expect this to throw an error for my-made-up-tag not being a known ruleset tag. However, it successfully returns 0 violations. (Presumably because the tag doesn't exist, so the rule-set that was checked is empty, thus finding 0 violations.)

Additionally:

a11yCheck({}, {
  runOnly: {
    type: "rule",
    values: ["fakeRule"]
  }
})

also successfully returns 0 violations, rather than an error even though fakeRule doesn't exist.

I would expect both of these scenarios (as well as with {rules: {fakeRule: {enabled:true}}}) to return errors stating that the rule ID or tag doesn't exist.

@dsturley dsturley added feat New feature or enhancement error handling labels Jul 29, 2015
@dylanb
Copy link
Contributor

dylanb commented Jan 29, 2016

depends on #83

@WilcoFiers
Copy link
Contributor

We currently have an implementation in our private repo which throws an error if this occurs. That wouldn't require the error first cb implementation.

felixzapata pushed a commit to felixzapata/axe-core that referenced this issue Aug 13, 2016
marcysutton pushed a commit that referenced this issue Apr 25, 2017
mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
chore: merge master into develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants