Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

td-has-headers takes 30+ seconds #908

Closed
patrickhulce opened this issue May 22, 2018 · 4 comments
Closed

td-has-headers takes 30+ seconds #908

patrickhulce opened this issue May 22, 2018 · 4 comments
Assignees
Labels
help wanted We welcome PRs or discussions for issues marked as help wanted performance Performance related issues
Milestone

Comments

@patrickhulce
Copy link

patrickhulce commented May 22, 2018

  1. Open https://www.guidetoonlineschools.com/online-schools
  2. Add axe 3.0.2 to the page (https://cdnjs.cloudflare.com/ajax/libs/axe-core/3.0.2/axe.js)
  3. Run td-has-headers rule in console
await window.axe.run(document, {
  elementRef: true,
  runOnly: {
    type: 'rule',
    values: ['td-has-header'],
  },
  resultTypes: ['violations', 'inapplicable'],
})
  1. Wait...

image

Seems like you might want to memoize toGrid or something, O(w^2*h^2) is rough :)

var tableGrid = commons.table.toGrid(commons.dom.findUp(cell, 'table'));

Originally reported in GoogleChrome/lighthouse#5249, Lighthouse axe run never completes within 60s


axe-core version: 3.0.2
chrome version: 66.0.3359.181

@paulirish
Copy link
Contributor

http://giveawaylisting.com/ takes over 3 minutes due to this issue.

@ggennrich
Copy link

Any update on this issue? We have a single page on our website that breaks due to this issue. Could someone explain in detail what exactly is breaking in lighthouse so that I have a better idea of what's going on? The fact this breaks on just one of our pages leads me to believe there is something unusual on the page. I'm worried this may be impacting our rankings as we noticed some drops in the last couple months.

@WilcoFiers
Copy link
Contributor

I'm not aware of anyone working on this issue. If you've got some time, we'd very much welcome some suggestions on how to improve the performance. A pull request would also be fantastic. Marking this as help wanted, as I don't see us prioritising this issue any time soon.

@padmavemulapati
Copy link

Not taking more than 2seconds for me, verified for axe-core:3.0.3 and chrome 78 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We welcome PRs or discussions for issues marked as help wanted performance Performance related issues
Projects
None yet
Development

No branches or pull requests

6 participants