Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: Document doesn't have a <title> element #5249

Closed
ggennrich opened this issue May 17, 2018 · 9 comments
Closed

False positive: Document doesn't have a <title> element #5249

ggennrich opened this issue May 17, 2018 · 9 comments

Comments

@ggennrich
Copy link

I am using Lighthouse CLI version 3.0.0-alpha.2. This is the command I am specifically running:
lighthouse --chrome-flags='--headless' https://www.guidetoonlineschools.com/online-schools
It is reporting that page as missing a title tag when it clearly isn't. Is this a known bug or am I missing something here?

@patrickhulce
Copy link
Collaborator

Interesting @ggennrich thanks for reporting I'm actually not able to get axe to finish running on this site at all! The entire accessibility category is just erroring 😕

We might need to escalate to axe folks, here.

@ggennrich
Copy link
Author

@patrickhulce Thanks for looking into this! Ya, the accessibility test hangs for a long time before finally moving on. The score for it in the HTML file just has a red question mark so I figured there was an issue with that, separate from the SEO title tag issue. Our homepage does not have the same accessibility issues. It has a score of 90. Also, there are no false positive title tag issues. So it appears that this only happens in specific cases and I haven't been able to figure it out.

@patrickhulce
Copy link
Collaborator

patrickhulce commented May 17, 2018

The SEO title audit is just reusing the accessibility audit under the hood, is this what you're seeing?
image

If so, we're not trying to communicate the document doesn't have a title, just that the audit that checks if you have a title errored :)

@ggennrich
Copy link
Author

@patrickhulce That is exactly what I am seeing. That totally makes sense. Why is it that the accessibility portion on this page errors then? Is that a separate issue or is there something wrong on this page that is causing that to happen?

@patrickhulce
Copy link
Collaborator

This is a bug with our integration with axe (the accessibility library that powers the audits). Typically it's because of a rare DOM structure on the page that axe isn't expecting, but either way we shouldn't take 60s of your time just to error so it's a bug to fix :)

@patrickhulce
Copy link
Collaborator

Filed the issue with axe 👍 dequelabs/axe-core#908

@luckyscript
Copy link

I have the same issue when I try to using light house on my own blog: https://www.luckyscript.me
but I cannot figure out what's wrong on my HTML DOM.

@patrickhulce
Copy link
Collaborator

@luckyscript your issue is slightly different, would you mind filing an issue with axe-core if their Chrome extension fails on your site too?

@brendankenny
Copy link
Member

FWIW the example page now passes (either changes in the page or in aXe updates), so I'm going to close. The underlying axe performance issue still exists; let's move tracking over to #5625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants