fix: consider element's accessible names when labels are hidden

[stephenmathieson]

Closes #1176

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

• Follows the commit message policy, appropriate for next version
• Has documentation updated, a DU ticket, or requires no documentation change
• Includes new tests, or was unnecessary
• Code is reviewed for security by: Marcy Sutton

[WilcoFiers]

I think this now fails if there is no label. Should probably just put the if statement back to the way it was.

[stephenmathieson]

Good catch. Will update!

Updated

[WilcoFiers]

We should change this so it does !axe.commons.dom.isVisible(label, true)).

Here's a test case for it:

it('should fail when the label has aria-hidden=true', function() {
	var html = '';
	html += '<div>';
	html += '  <label for="target" aria-hidden="true">';
	html += '    Hello world';
	html += '  </label>';
	html += '  <input id="target">';
	html += '</div>';
	var args = checkSetup(html, {}, '#target');
	assert.isTrue(check.evaluate.apply(check, args));
});

[stephenmathieson]

Good call! Updated.

Updated