Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Resolve a few a11y-name comments #1376

Merged
merged 4 commits into from
Feb 18, 2019
Merged

chore: Resolve a few a11y-name comments #1376

merged 4 commits into from
Feb 18, 2019

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Feb 18, 2019 •
edited by jeeyyy

Following up on a few comments in #1163

Closes issue: none

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @JKODU

@WilcoFiers WilcoFiers requested a review from a team as a code owner February 18, 2019 10:21
jeeyyy
jeeyyy previously approved these changes Feb 18, 2019
View reviewed changes
@dylanb dylanb merged commit 6843b7b into develop Feb 18, 2019
@dylanb dylanb deleted the a11yname-comments branch February 18, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanb dylanb dylanb approved these changes

@jeeyyy jeeyyy jeeyyy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilcoFiers @dylanb @jeeyyy