fix: Avoid require conflict with Cypress [#1405]

[WilcoFiers]

Use derequire the rename all uses of require to _dereq_ to avoid the problem of Cypress overloading the require method.

Closes #1405

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

• Follows the commit message policy, appropriate for next version
• Has documentation updated, a DU ticket, or requires no documentation change
• Includes new tests, or was unnecessary
• Code is reviewed for security by: Stephen

[stephenmathieson]

This seems scary. I'd like to hear more about why this is necessary before OK'ing the code.

[WilcoFiers]

@stephenmathieson Cypress seems to be replacing any variable with the name require with its own require method. I didn't dig into exactly why that is. I searched, but couldn't find any documentation about this. Renaming all uses of require to _dereq_ gets around that problem.

What is your concern with doing this? I realise that if derequire messes up, this could go wrong, but the same is true for browserify. That's why I used derequire, it's made to do this.

[stephenmathieson]

Cypress seems to be replacing any variable with the name require with its own require method. I didn't dig into exactly why that is. I searched, but couldn't find any documentation about this.

Wow, OK. That's very strange. I wonder why that is 🤔

What is your concern with doing this?

I'm just worried about adding another layer of transformation to the codebase, especially since in this PR we're transforming code that we don't own/maintain (dot, axios, and es-promise). It's generally recommended that you do not run Babel/etc over your node_modules, so I'm of the same mindset with the "derequire" transformation.

However, since this is urgent, and the tests are all green, let's give this a go 😄

[stephenmathieson]

Not a blocker, just a thought -- would it make more sense to use this as a Browserify transform?

[stephenmathieson]

However, since this is urgent, and the tests are all green, let's give this a go 😄

I was wrong. Tests are now failing. Seems like some tests intermittently fail.

[stephenmathieson]

Based on #1427, it seems like using axe-core in Cypress still isn't working as expected.

[artemkochnev]

@stephenmathieson I just want to add that the issue I'm seeing only exists when using webpack to preprocess files. If I let Cypress manage things itself, using axe-core works without issue.

[YOU54F]

This is an issue with webpack, I have switched to

https://github.com/cypress-io/cypress-browserify-preprocessor

which has resolved the issue.