Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add list of required globals #1622

Merged
merged 1 commit into from
Jun 7, 2019
Merged

docs: add list of required globals #1622

merged 1 commit into from
Jun 7, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 6, 2019 •
edited by WilcoFiers
Loading

Closes issue: #1531

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@straker straker requested a review from a team as a code owner June 6, 2019 21:00
stephenmathieson
stephenmathieson reviewed Jun 6, 2019
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't verified this list.

@straker straker merged commit a36f72a into develop Jun 7, 2019
@straker straker deleted the requiredGlobals branch June 7, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson left review comments

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@jeeyyy jeeyyy jeeyyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@straker @WilcoFiers @stephenmathieson @jeeyyy