Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(label-content-name-mismatch): ignore private space unicode #1822

Merged
merged 5 commits into from
Sep 30, 2019
Merged

fix(label-content-name-mismatch): ignore private space unicode #1822

merged 5 commits into from
Sep 30, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Sep 24, 2019 •
edited by WilcoFiers
Loading

Part 1 for #1635 to fix using private use unicode characters.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner September 24, 2019 19:24
@straker straker changed the title fix(label-content-name-mismatch): ignore private space unicode code characters fix(label-content-name-mismatch): ignore private space unicode Sep 24, 2019
jeeyyy
jeeyyy previously requested changes Sep 25, 2019
View reviewed changes
lib/commons/text/unicode.js Show resolved Hide resolved
@straker straker merged commit b634c34 into develop Sep 30, 2019
@straker straker deleted the fixLabelContentName branch September 30, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@jeeyyy jeeyyy jeeyyy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@straker @WilcoFiers @jeeyyy