Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: add tags with dots for wcag sc (#1849) #1851

Merged
merged 1 commit into from
Oct 17, 2019
Merged

revert: add tags with dots for wcag sc (#1849) #1851

merged 1 commit into from
Oct 17, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Oct 16, 2019 •
edited by WilcoFiers
Loading

This reverts commit 2f1ab36.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner October 16, 2019 13:59
@stephenmathieson
Copy link
Member

Why is this being reverted?

@straker
Copy link
Contributor Author

straker commented Oct 16, 2019

Wilco didn't want it in:

A change like that has implications for the whole company. I don’t know the down stream effects of it
I also don’t know what that change would mean for our other products

@WilcoFiers WilcoFiers changed the title Revert "fix: add tags with dots for wcag sc (#1849)" revert: add tags with dots for wcag sc (#1849) Oct 17, 2019
@straker straker merged commit 9bc1628 into develop Oct 17, 2019
@straker straker deleted the revertTags branch October 17, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@straker @stephenmathieson @WilcoFiers