fix(color-contrast): parse font-weight value as number (#2031) #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The computed values of `font-weight` are numeric string so that we don't need to check keywords such as `bold`. The `font-weight` values are continuous. They can be `123` or `123.4` so that we should parse them as number. https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Fonts/Variable_Fonts_Guide
WilcoFiers
approved these changes
Feb 12, 2020
|
@tabushaban Thank you for the contribution! |
straker
pushed a commit
that referenced
this pull request
Feb 12, 2020
The computed values of `font-weight` are numeric string so that we don't need to check keywords such as `bold`. The `font-weight` values are continuous. They can be `123` or `123.4` so that we should parse them as number. https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Fonts/Variable_Fonts_Guide Co-authored-by: Takeshi Kurosawa <kurosawa-takeshi@mitsue.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computed values of
font-weightare numeric string so that we don't need to check keywords such asbold.The
font-weightvalues are continuous. They can be123or123.4so that we should parse them as number.https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Fonts/Variable_Fonts_Guide
<< Describe the changes >>
Closes issue: #2031
Reviewer checks
Required fields, to be filled out by PR reviewer(s)