Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast): ignore form elements that move text outside of node using text-indent #2044

Merged
merged 2 commits into from
Feb 19, 2020
Merged

fix(color-contrast): ignore form elements that move text outside of node using text-indent #2044

merged 2 commits into from
Feb 19, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Feb 12, 2020 •
edited by WilcoFiers
Loading

Closes issue: #1886

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner February 12, 2020 21:15
@straker straker changed the title fix(color-contrast): ignore from elements that move text outside of node using text-indent fix(color-contrast): ignore form elements that move text outside of node using text-indent Feb 13, 2020
WilcoFiers
WilcoFiers previously requested changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak

lib/rules/color-contrast-matches.js Outdated Show resolved Hide resolved
@straker straker merged commit 104834f into develop Feb 19, 2020
@straker straker deleted the textIndent branch February 19, 2020 18:38
straker added a commit that referenced this pull request Mar 6, 2020
@straker
fix(color-contrast): ignore form elements that move text outside of n…
85cc6ab 
…ode using text-indent (#2044)

* fix(color-contrast): ignore from elements that move text outside of node using text-indent

* dont checkout styles unless form element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers