Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button-name): work with serial virtual node #2351

Merged
merged 1 commit into from
Jul 9, 2020
Merged

fix(button-name): work with serial virtual node #2351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/checks/shared/button-has-visible-text.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"impact": "critical",
"messages": {
"pass": "Element has inner text that is visible to screen readers",
"fail": "Element does not have inner text that is visible to screen readers"
"fail": "Element does not have inner text that is visible to screen readers",
"incomplete": "Unable to determine if element has children"
}
}
}
12 changes: 12 additions & 0 deletions test/checks/shared/button-has-visible-text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,16 @@ describe('button-has-visible-text', function() {
.apply(checkContext, checkArgs)
);
});

describe('SerialVirtualNode', function() {
it('should return undefined if no other attributes are provided', function() {
var node = new axe.SerialVirtualNode({
nodeName: 'button'
});

assert.isUndefined(
axe.testUtils.getCheckEvaluate('has-visible-text')(null, {}, node)
);
});
});
});