feat(presentation-role-conflict): create rule to flag elements with role conflict resolution #2284 #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
reviewed
Aug 10, 2020
straker
reviewed
Aug 10, 2020
straker
reviewed
Aug 10, 2020
straker
reviewed
Aug 10, 2020
straker
reviewed
Aug 10, 2020
lib/rules/flag-role.json
Outdated
| "help": "Elements of role none or presentation should be flagged" | ||
| }, | ||
| "preload": false, | ||
| "all": ["is-element-focusable", "has-global-aria-attribute"], |
There was a problem hiding this comment.
So this will pass the rule if the element is both focusable and has a global aria attribute. Instead it should fail the rule, so I believe these should be in the none array.
straker
reviewed
Aug 10, 2020
straker
reviewed
Aug 10, 2020
straker
requested changes
Aug 10, 2020
WilcoFiers
reviewed
Aug 11, 2020
straker
requested changes
Sep 14, 2020
|
Oh, and also to fix the tests you'll need to update to the latest develop again (we disabled chrome-mobile because it started giving us problems). |
straker
approved these changes
Sep 23, 2020
straker
changed the title
|
Thank you @WilcoFiers @straker for guidance and review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create best practice rule to flag elements with role conflict resolution #2284
Reviewer checks
Required fields, to be filled out by PR reviewer(s)