feat(role-text): add role-text rule #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
commented
Dec 18, 2020
WilcoFiers
previously requested changes
Dec 21, 2020
WilcoFiers
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
role=textonly if the contents do not have focusable descendants. This is very similar to our newnested-interactiverule except that instead of focusing on interactive roles this focuses on making sure thetextrole is used in such a way that does not override the semantics of the children.Now we could have made
role=textalso havechildrenPresentational: true, but that means it would have thrown errors with thenested-interactiverule which didn't make much sense (it's not really an interactive component). This allows use to have its own rule page with an explanation on the proper use.Also note that this allows
role=texton any element that is allowed any role. This means you can doAnd it will pass. I figured this was fine since these elements do allow any role to begin with.
Closes issue: #1597