Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(heading-order): use aria-level on headings in addition to role=header elements #3028
fix(heading-order): use aria-level on headings in addition to role=header elements #3028
Changes from 4 commits
0d6604b
0a12490
0ce2ebd
a6fe4be
5687697
6d991a6
eeb6f7e
1be1e8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Wilco and I talked and we came to the conclusion that we want to change how we're handling positive values. Since
aria-level
> 6 is handled differently by different screen readers, we're going to flag it as part of a new check for aria-valid-attr-value and call out its lack of support.But for heading-order we're just going to accept what the user gave us so there isn't two different failures caused by the same problem.