-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add matrix node test #4275
ci: add matrix node test #4275
Conversation
…into matrix-tests
…into matrix-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small questions.
@@ -17,7 +17,7 @@ jobs: | |||
cache: 'npm' | |||
# Workflows are not allowed to edit workflows. As result, we need to prevent Prettier from formatting them. | |||
- name: Prevent workflows from being formatted | |||
run: echo ".github" >> .prettierignore | |||
run: echo ".github" >> .prettierignore && cat .prettierignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line wasn't working correctly and was failing the build as the .prettierignore
file didn't have a newline character at the end of the file. So instead of appending a new line item this was appending to the end of the last item. Left this in for easier debugging.
node_modules/
doc/api.github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I verified that locally reverting the fix from #4274 results in the new test correctly failing.
Adds a matrix test to test running axe-core in all supported node versions. Currently does not test node 4 support as it turns out axe-core does not work in node 4 as we use
array.prototype.includes
without a polyfill which doesn't exist in node 4. Will make a new pr after this is merged to add that as afix
.