ci: add matrix node test #4275
Merged
ci: add matrix node test #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into matrix-tests
…into matrix-tests
WilcoFiers
previously requested changes
Dec 18, 2023
straker
commented
Dec 18, 2023
| @@ -17,7 +17,7 @@ jobs: | |||
| cache: 'npm' | |||
| # Workflows are not allowed to edit workflows. As result, we need to prevent Prettier from formatting them. | |||
| - name: Prevent workflows from being formatted | |||
| run: echo ".github" >> .prettierignore | |||
| run: echo ".github" >> .prettierignore && cat .prettierignore | |||
There was a problem hiding this comment.
This line wasn't working correctly and was failing the build as the .prettierignore file didn't have a newline character at the end of the file. So instead of appending a new line item this was appending to the end of the last item. Left this in for easier debugging.
node_modules/
doc/api.github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a matrix test to test running axe-core in all supported node versions. Currently does not test node 4 support as it turns out axe-core does not work in node 4 as we use
array.prototype.includeswithout a polyfill which doesn't exist in node 4. Will make a new pr after this is merged to add that as afix.