style: var -> let and const codemod
#4444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds `no-var` rule to eslint Who else does this? - Google (JS style guide) https://google.github.io/styleguide/jsguide.html#features-local-variable-declarations - Airbnb (popular JS style guide) https://github.com/airbnb/javascript Why do this? Gaiety's explanation: "`let` works the way most devs think `var` works. scope leaking and variable hoisting is a messy confusing idea, JS got updated for a reason" also it's 2024, this isn't too controversial anymore - https://www.freecodecamp.org/news/var-let-and-const-whats-the-difference/ - https://blog.javascripttoday.com/blog/var-vs-let-vs-const/ "The var keyword was originally used for declaring variables in JavaScript. If you’ve browsed an old codebase or an older JavaScript tutorial, you have probably seen it." - https://medium.com/@rithinmenezes/understanding-let-var-and-const-in-javascript-a-guide-to-variable-declarations-f271c5b8dc79 - Airbnb's why https://airbnb.io/javascript/#variables
gaiety-deque
commented
May 3, 2024
| @@ -7,5 +7,6 @@ doc/api/* | |||
| doc/examples/jest_react/*.js | |||
|
|
|||
| lib/core/imports/*.js | |||
| lib/core/utils/uuid.js | |||
There was a problem hiding this comment.
Not really our code, maybe belongs in a vendor file? Felt weird touching it.
|
Closing this in favor of doing smaller PR's piece by piece over time, but I'll reference the changes here as the ultimate goal. |
gaiety-deque
added a commit
that referenced
this pull request
May 7, 2024
This is a piece of a larger creative time PR so it's easier to review, the full scope can be seen here and includes eslint adjustments not seen here #4444 --- Who else does this? - Google (JS style guide) https://google.github.io/styleguide/jsguide.html#features-local-variable-declarations - Airbnb (popular JS style guide) https://github.com/airbnb/javascript Why do this? Gaiety's explanation: "`let` works the way most devs think `var` works. scope leaking and variable hoisting is a messy confusing idea, JS got updated for a reason" also it's 2024, this isn't too controversial anymore - https://www.freecodecamp.org/news/var-let-and-const-whats-the-difference/ - https://blog.javascripttoday.com/blog/var-vs-let-vs-const/ "The var keyword was originally used for declaring variables in JavaScript. If you’ve browsed an old codebase or an older JavaScript tutorial, you have probably seen it." - https://medium.com/@rithinmenezes/understanding-let-var-and-const-in-javascript-a-guide-to-variable-declarations-f271c5b8dc79 - Airbnb's why https://airbnb.io/javascript/#variables
gaiety-deque
added a commit
that referenced
this pull request
May 10, 2024
gaiety-deque
added a commit
that referenced
this pull request
Jun 6, 2024
gaiety-deque
added a commit
that referenced
this pull request
Jun 6, 2024
gaiety-deque
added a commit
that referenced
this pull request
Jun 7, 2024
gaiety-deque
added a commit
that referenced
this pull request
Jun 13, 2024
WilcoFiers
pushed a commit
that referenced
this pull request
Jun 17, 2024
For `test/rule-matches` Smaller part of the full vision: #4444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
no-varrule to eslint(this also pairs well with the already enabled
prefer-constandno-redeclare)Who else does this?
Why do this?
Gaiety's explanation: "
letworks the way most devs thinkvarworks. scope leaking and variable hoisting is a messy confusing idea, JS got updated for a reason" also it's 2024, this isn't too controversial anymore<< Describe the changes >>
Closes: