New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(lib/checks): var -> let and const codemod #4451

Merged

gaiety-deque merged 1 commit into develop from var-to-let-libchecks

May 7, 2024

Commits on May 7, 2024

style(lib/checks): var -> let and const codemod

Who else does this?
  - Google (JS style guide) https://google.github.io/styleguide/jsguide.html#features-local-variable-declarations
  - Airbnb (popular JS style guide) https://github.com/airbnb/javascript

Why do this?

Gaiety's explanation: "`let` works the way most devs think `var` works.
scope leaking and variable hoisting is a messy confusing idea, JS got
updated for a reason" also it's 2024, this isn't too controversial
anymore

- https://www.freecodecamp.org/news/var-let-and-const-whats-the-difference/
- https://blog.javascripttoday.com/blog/var-vs-let-vs-const/ "The var
  keyword was originally used for declaring variables in JavaScript. If
  you’ve browsed an old codebase or an older JavaScript tutorial, you
  have probably seen it."
- https://medium.com/@rithinmenezes/understanding-let-var-and-const-in-javascript-a-guide-to-variable-declarations-f271c5b8dc79
- Airbnb's why https://airbnb.io/javascript/#variables

gaiety-deque committed May 7, 2024