This repository has been archived by the owner on Nov 4, 2020. It is now read-only.
feat: implement smaller FTPO arrow #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE
|
|
| left: 6px; | ||
| width: 89px; | ||
| height: 38px; | ||
| @arrowPointer: %('data:image/svg+xml;charset=utf-8,%s', escape(%('<svg xmlns="http://www.w3.org/2000/svg" width="33" height="22"><path d="M 13,2 C 15,0 16,0 18,2 L 28,13 C 30,15 30,17 28,17 L 22.5,17 L 3,17 C 1,17 1,15 3,13 Z" fill="%s" stroke="%s" stroke-linejoin="round" transform="translate(0 3)" stroke-width="3"></path></svg>', @tile-bg, @focus-glow))); |
There was a problem hiding this comment.
Wow, LESS is weird. This looks nothing like CSS 🤷♂
schne324
pushed a commit
that referenced
this pull request
Sep 3, 2019
BREAKING CHANGE: footprint of arrow has been changed to be smaller.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses an svg (as a data-uri) as the arrow pointer instead of using a a rotated box as there was a lot of magic css involved to create that. This is a breaking change, and there will need to be some downstream updates in cauldron-react to implement the changes here.
fixes #122
fixes #117
closes #124