Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting a daemonset removes the daemonset but keeps the pods #212

Closed
ghost opened this issue Jun 4, 2019 · 5 comments
Closed

deleting a daemonset removes the daemonset but keeps the pods #212

ghost opened this issue Jun 4, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jun 4, 2019




Describe the bug
deleting a daemonset removes the daemonset but keeps the pods

To Reproduce
Steps to reproduce the behavior:

  1. navigate to daemonset view
  2. delete daemonset (ctrl-d)

Expected behavior
daemonset and pods should be removed

Versions (please complete the following information):

  • OS: OSX
  • K9s 0.7.1
  • K8s 1.13.6
@derailed derailed added the question Further information is requested label Jun 4, 2019
@derailed
Copy link
Owner

derailed commented Jun 4, 2019

@devkws Thank you for the report! That's definitely surprising. K9s is not doing anything to prevent that behavior. Will need to research if feature or bug?? As my current understanding is upon ds delete all associated pods should be deleted unless cascade is set to false which is not the case here in k9s??

@ghost
Copy link
Author

ghost commented Jun 4, 2019

@derailed that’s my understanding as well and in fact kubectl and the GKE dashboard does just that. I’m wondering now if it was because the pods were in a crashloop. But again, kubectl and GKE removed the underlying pods. Weird.

@thllxb
Copy link

thllxb commented Jun 5, 2019

@devkws kubectl has the cascade option set to true by default when deleting. This is why when you delete a DS or RC, all the underlying pods are deleted as well. Apparently k9s doesn't have this option, or it has it hardcoded to false.
@derailed It needs to be a config item in the config file, or on the UI, to match the default behavior of kubectl. https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/types.go#L506 should be useful.

@derailed
Copy link
Owner

derailed commented Jun 6, 2019

@thllxb Thank you so much for your input and research! I've looked into it and agree with your assessment. I'll fix the behavior in the next drop.

@derailed derailed added bug Something isn't working and removed question Further information is requested labels Jun 6, 2019
@derailed
Copy link
Owner

derailed commented Jun 7, 2019

@devkws @thllxb Fixed 0.7.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants