Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Item highlighting broke in v0.29.0 #2327

Closed
krzwiatrzyk-lgd opened this issue Dec 7, 2023 · 11 comments
Closed

[Bug] Item highlighting broke in v0.29.0 #2327

krzwiatrzyk-lgd opened this issue Dec 7, 2023 · 11 comments

Comments

@krzwiatrzyk-lgd
Copy link




Describe the bug
After upgrade to v0.29.0, items loose their colors (no custom theme used!) and item selecting doesn't highliting item, it makes it disappear.

To Reproduce
Steps to reproduce the behavior:

  1. Download v0.29.0 on MacOS

Expected behavior
Item properly highlighted.

Screenshots
Highlighted bar:
image

Trying to hightlight item (item is not shown):
image

Versions (please complete the following information):

  • OS: MacOS 13.4.1
  • K9s: v0.29.0
  • K8s: 1.25.15
@lukasjelonek
Copy link

I have the same problem on windows with git-bash terminal and powershell.

@krzwiatrzyk-lgd krzwiatrzyk-lgd changed the title Item highlighting broke in v0.29.0 [Bug] Item highlighting broke in v0.29.0 Dec 7, 2023
@lukasjelonek
Copy link

I observed some weird behaviour:

I have different k8s contexts configured. Depending on the context, I either saw the colors I had in the previous version of k9s or the problem with the invisible lines. After adding the example skin from the themes page and changing contexts for a while, deleting the skin and changing contexts more times, now all contexts show the correct colors.

Maybe it is some configuration error? Or is there some caching involved? Maybe it helps to recreate the k9s config?

@krzwiatrzyk-lgd
Copy link
Author

I have done that (remove config.yml and let K9s to create new one) - doesn't help in my case.

@armangurkan
Copy link

same problem arch linux

@Mikakakaka
Copy link

Same issue here with fresh install on Ubuntu.
I removed all config files, tried the cluster specific conf, I've tried moving yml files in the ~/.config/k9s/skins/ folder, tried in the /k9s/ folder, didn't help.

@lukasjelonek
Copy link

lukasjelonek commented Dec 7, 2023

I found a solution for me:

In my kubeconfig file the names of the clusters with the ui-problems had different names that the contexts referencing them.

clusters:
  - cluster: 
    [...]
    name: abcd
contexts:
  - context:
      cluster: abcd
      [...]
    name: my-context
[...]

When I use the same name for the cluster and the context, everything works fine again.

clusters:
  - cluster: 
    [...]
    name: abcd
contexts:
  - context:
      cluster: abcd
      [...]
    name: abcd
[...]

So the bug seems to be that k9s has problems when a cluster has a different name than the context that references it.

@alewis001
Copy link

The behaviour identified by @lukasjelonek also affects skin loading in v0.29.0. Once the context name matches the cluster name, the right skin from config.yml is loaded as expected. This issue is worse when you work with aws EKS as the cluster and context names are very long so it's more likely that users might rename contexts to make them useful.

@derailed
Copy link
Owner

derailed commented Dec 7, 2023

@krzwiatrzyk-lgd Thank you all for the heads up and details! sorry for the mess...
Rats! That's on me.
Let's see if we're happier on v0.29.1...

@NeckBeardPrince
Copy link
Sponsor

@krzwiatrzyk-lgd Thank you all for the heads up and details! sorry for the mess... Rats! That's on me. Let's see if we're happier on v0.29.1...

Seems to be fixed now. Thank you!

@derailed
Copy link
Owner

derailed commented Dec 7, 2023

Thank you all for reporting back! Fixed in v0.29.1...

@derailed derailed closed this as completed Dec 7, 2023
@alewis001
Copy link

I can also confirm the fix in v0.29.1, thank you!

thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this issue Feb 23, 2024
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants