Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening screen dumps (sd) in K9s results in Failed to launch editor error message #2538

Closed
alextricity25 opened this issue Feb 14, 2024 · 1 comment
Closed

Opening screen dumps (sd) in K9s results in Failed to launch editor error message #2538

alextricity25 opened this issue Feb 14, 2024 · 1 comment
Labels
bug Something isn't working InProgress Marks an issue has being worked on

Comments

@alextricity25
Copy link

image


Describe the bug
Opening screed dumps (sd) in K9s results in Failed to launch editor error message, even though my EDITOR environment variable is set.

To Reproduce

  1. Ctrl+s to save a screen dump of a pod's log
  2. Go to screen dumps (:sd)
  3. Attempt to open screen dump by hitting "Enter"

Historical Documents
When applicable please include any supporting artifacts: k9s debug logs, configurations, resource manifests, ...

Expected behavior
No error.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

  • OS: MacOS 14.2.1
  • K9s: 0.31.8
  • K8s: 1.27.7

Additional context
Add any other context about the problem here.
@derailed derailed added bug Something isn't working InProgress Marks an issue has being worked on labels Feb 15, 2024
@derailed derailed changed the title Opening screed dumps (sd) in K9s results in Failed to launch editor error message Opening screen dumps (sd) in K9s results in Failed to launch editor error message Feb 15, 2024
derailed added a commit that referenced this issue Feb 16, 2024
@derailed
[Bug] fix #2538
c322761
@derailed derailed mentioned this issue Feb 16, 2024
Merged
@alextricity25
Copy link
Author

Can confirm that the fix works on v0.31.9! Thanks @derailed !!

placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
@derailed
K9s/release v0.31.9 (derailed#2543)
8064419 
* [Bug] fix derailed#2535

* [Bug] fix derailed#2532

* [Bug] fix derailed#2536

* [Bug] fix derailed#2533

* [Bug] fix derailed#2538

* [Maint] cleaning up

* Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working InProgress Marks an issue has being worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derailed @alextricity25