Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pod count onto Node view #797

Closed
thllxb opened this issue Jul 8, 2020 · 15 comments
Closed

add pod count onto Node view #797

thllxb opened this issue Jul 8, 2020 · 15 comments
Labels
enhancement New feature or request

Comments

@thllxb
Copy link

thllxb commented Jul 8, 2020

Please add pod count onto Node view to show the number of pods running on each node


Is your feature request related to a problem? Please describe.
Nope

Describe the solution you'd like
Add a pod count column onto Node view

Describe alternatives you've considered
now I have to do it through kubectl and wc -l

Additional context

@derailed derailed added the enhancement New feature or request label Jul 8, 2020
@derailed
Copy link
Owner

@thllxb I think you can press enter for a given node and it should show all the pods (with count) running on that node. Does that help?

@thllxb
Copy link
Author

thllxb commented Jul 23, 2020

@derailed Thx for the reply. I know I can see the pod count when I press enter on the node, but I was looking for an overview of pod counts on all node instead of a single node view.
I do admit this is a very minor feature and not important at all. I'm happy with the current design already. You may close this issue if you think the same.

@derailed
Copy link
Owner

@thllxb Thank you! Very kind of you to say. I'll need to noodle on this a bit but I think it will slow things down loading the view as these aren't (currently) precomputed tallies. What would showing the #pods per nodes indicate for you?

@thllxb
Copy link
Author

thllxb commented Jul 23, 2020

Azure AKS has the limit of 30 pods per node. So, for me, it is something I would have to check every now and then. When we have 50+ nodes, it is a lot of enter to press.

@derailed
Copy link
Owner

@thllxb Ah! indeed excellent point! Thank you!! I'll take a peek...

@thllxb
Copy link
Author

thllxb commented Jul 23, 2020

But, again, I have kubectl and wc -l at hand, so it is not a big deal to not have this feature in k9s.

@derailed
Copy link
Owner

@thllxb Totally! I do see your point and think this could be useful to other K9ers as well. Would you be ok if the pod counts are eventually consistent ie depending on your cluster size the numbers would eventually report the actual tally of pods? If so I think we can make this happen...

@thllxb
Copy link
Author

thllxb commented Jul 23, 2020

@derailed Sorry, I don't think I understand your question. What is pod counts are eventually consistent?

@derailed
Copy link
Owner

@thllxb yes sorry... by that I mean that on first load the counts might be a tad off based on whether the pod cache is up to date or not. Then the view will zero in on the actual counts once the k9s cache is updated. Does this make more sense?

@derailed
Copy link
Owner

@thllxb Let's try this out in the next drop (0.21.4). If problematic will pull it out. Lmk what u think and if it fits the bill...
Tx!!

derailed added a commit that referenced this issue Jul 24, 2020
@thllxb
Copy link
Author

thllxb commented Jul 24, 2020

@derailed
I tried 0.21.4, and it is great! Now I understand what you meant but it is completely fine for me.
Thanks a lot for the improvement!

@thllxb thllxb closed this as completed Jul 24, 2020
@derailed
Copy link
Owner

@thllxb My pleasure! You've been kind enough to make the effort to sponsor the K9s project and in turn I'd like to make the effort to help better your k8s experience. It makes me happy to hear, this is what you were looking for. Thank you!

@Xyaren
Copy link

Xyaren commented Aug 27, 2021

I think this feature causes me problems:
It is no longer possible to list nodes without havin permissions on pods on a cluster level :/

@thllxb
Copy link
Author

thllxb commented Aug 29, 2021

I think this feature causes me problems:
It is no longer possible to list nodes without havin permissions on pods on a cluster level :/

@derailed If you want to fix this problem by removing the feature, I'm ok with it.

@Xyaren
Copy link

Xyaren commented Aug 29, 2021

If don't think thats neccecary. It just should not break the node view. You could maybe display a "?" or remove the column entirely when the get-pods request failes due to rbac :)

placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants