fix namespace suggestion error on context switch #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derailed
requested changes
Nov 27, 2023
internal/view/app.go
Outdated
| @@ -55,6 +55,7 @@ type App struct { | |||
| showHeader bool | |||
| showLogo bool | |||
| showCrumbs bool | |||
| namespaces []string | |||
There was a problem hiding this comment.
Likely not a good idea to cache the namespaces here as the list will change over the course of the session.
wjiec
force-pushed
the
bugfix/switch-ctx
branch
from
0885704
to
88c309e
Compare
|
If the namespace is already cached in lru map, then we just refetch it every time? |
derailed
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
@wjiec Thank you for the updates Jayson!!
Yes I think that is fine for the time being.
I do think namespaceNames and contextNames should live in the client package.
There is a similar call client.NamespaceNames available but we should replace with your impl.
We can do thsese in a separate PR.
Merged
thejoeejoee
pushed a commit
to thejoeejoee/k9s
that referenced
this pull request
Feb 23, 2024
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is used to supplement what was missing in #2285 and fixes a few issues.