Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supports referencing envs in hotkeys #2420

Merged
merged 3 commits into from Jan 4, 2024
Merged

supports referencing envs in hotkeys #2420

merged 3 commits into from Jan 4, 2024

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Jan 3, 2024

related issues: #2334.

This PR introduces a new setting to the hotkeys, allowing one to choose if the current view should be kept. for example:

hotKeys:
  ctrl-u:
    shortCut:    Ctrl-U
    description: Namespaced resources
    command:     "$RESOURCE_NAME $NAMESPACE"
    navigable:   true

derailed
derailed reviewed Jan 3, 2024
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Very cool! Thank you for this update Jayson!!
Not sure if I have a better attr name for you.
Let me know if any of the alternates makes better sense??

internal/config/hotkey.go Outdated
@@ -19,6 +19,7 @@ type HotKey struct {
ShortCut string `yaml:"shortCut"`
Description string `yaml:"description"`
Command string `yaml:"command"`
Navigable bool `yaml:"navigable"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigable feels a bit odd. Not sure if I have a better term tho?
Was thinking asBreadCrumb, 'asTab' or asChild or keepHistory ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keepHistory is better :)

derailed
derailed approved these changes Jan 4, 2024
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Sold! Thank you for the updates Jayson.

@derailed derailed merged commit 3137b2b into derailed:master Jan 4, 2024
2 of 3 checks passed
@wjiec
Copy link
Contributor Author

wjiec commented Jan 4, 2024

Cool!

@wjiec wjiec deleted the feat/envs-for-hotkeys branch January 4, 2024 05:57
@derailed derailed mentioned this pull request Jan 9, 2024
Merged
thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this pull request Feb 23, 2024
@wjiec @thejoeejoee
supports referencing envs in hotkeys (derailed#2420)
91012be 
* supports referencing envs in hotkeys

* add testcase for hotkeys

* rename attr name to keepHistory
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
@wjiec
supports referencing envs in hotkeys (derailed#2420)
bc8ea6d 
* supports referencing envs in hotkeys

* add testcase for hotkeys

* rename attr name to keepHistory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjiec @derailed