Adding system arch to nodes view #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derailed
reviewed
Jan 16, 2024
derailed
added
enhancement
|
@guanchzhou Thank you for the updates! Looks like the tests are not happy ;( |
Yes, my bad. FIxed that and test locally, all looks good. |
Merged
|
Great feature, but I don't see it. Do I need to do anything to get it showing? |
basically, in nodes view press ctrl-w to toggle wide mode and you will see it there
|
Yep. Works as expected 😄 |
thejoeejoee
pushed a commit
to thejoeejoee/k9s
that referenced
this pull request
Feb 23, 2024
* adding arch to nodes view * hiding arch under wide view and fix test * fixing tests --------- Co-authored-by: Andrei Maltsev <amaltsev@alpha-sense.com>
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
* adding arch to nodes view * hiding arch under wide view and fix test * fixing tests --------- Co-authored-by: Andrei Maltsev <amaltsev@alpha-sense.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces system architecture column in node view.
It may be helpfull for activities like migration from amd64 to arm64 nodes.