fix the --write flag #2531
Merged
fix the --write flag #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--write sets k.manualReadOnly to false, but this was previously setting the read only state to true if k.manualReadOnly was set at all
adelowo
approved these changes
Feb 10, 2024
derailed
approved these changes
Feb 15, 2024
|
Fixes #2540 |
Merged
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
--write sets k.manualReadOnly to false, but this was previously setting the read only state to true if k.manualReadOnly was set at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--write sets k.manualReadOnly to false, but this was previously setting the read only state to true if k.manualReadOnly was set at all
fixes #2371 (again)