Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable header toggle when buffer is active. #360

Merged
merged 1 commit into from Oct 17, 2019
Merged

disable header toggle when buffer is active. #360

merged 1 commit into from Oct 17, 2019

Conversation

paivagustavo
Copy link
Contributor

After changing the 'header toggle' key to H, it became impossible to type the letter h on the command and filter buffer.

I've added a guard when either the command buffer or the filter buffer is active to prevent the toggle.

Out of the scope: @derailed do you want me to create issues for small fixes like this or do you think we can skip it?

@derailed
Copy link
Owner

@paivagustavo Thank you for looking at this! I've actually fixed this issue. Sitting on a bit of changes at the moment and can't update quiet yet. Would you mind making the change in this PR and I will merge it?

BTW This is on me! Pushed the change without really thinking. Sick as a dog this week, so brain is far from nominal ;(

I think we don't need to introduce new state here. All we need is to check if the cmdView on the app is in command mode which will trap both the command and search buffers activity. ie

func (a *appView) toggleHeaderCmd(evt *tcell.EventKey) *tcell.EventKey {
  if a.Cmd().InCmdMode() {
     return evt
}
...
}

I am in the process of refactoring a bit of the code, so I think it's best for now to continue to track these with PRs. At some point we should get together and discuss K9s future roadmap so you could help me (if you wish??) with bigger stories and feature work. 

Thank you for your help Gustavo!!

@paivagustavo
Copy link
Contributor Author

Oh, I didn't know about InCmdMode, I've changed to that!

About discussing the future of k9s, I would love to discuss and help with bigger changes. If you allow, I have a friend that uses kubernetes and k9s a lot, I think he would be a great person to help with feature design and in the future help coding (although he is still learning go, I'm trying to bring people from my work to code in Go more :D) and I'm sure he would be willing to help. Just tell what works best for you and when you want to talk.

We probably need a place to chat more about the project and improve our communication so we don't work on the same thing at the same time and etc.

@derailed derailed merged commit c557f2d into derailed:master Oct 17, 2019
@derailed
Copy link
Owner

@paivagustavo Thank you for this update! Yes I think I am going to setup a K9s slack channel for K9sers to hangout and interact. I'll publicize and amplify when ready.
Thank you Gustavo!!

@paivagustavo paivagustavo deleted the headler-toggle-when-filtering branch October 17, 2019 14:17
@paivagustavo
Copy link
Contributor Author

@derailed I think we should request a channel on the Kubernetes slack. If you agree, I could request it.

placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
…-filtering

disable header toggle when buffer is active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants