Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore PodSecurityPolicies in Kubernetes >= 1.25 #239

Closed
wants to merge 2 commits into from

Conversation

jon4hz
Copy link

@jon4hz jon4hz commented Dec 24, 2022

Hi, this PR disables scanning for PodSecurityPolicies in Kubernetes > 1.25.

Closes #236

@jon4hz jon4hz changed the title fix: ignore PodSecurityPolicies in Kubernetes > 1.25 fix: ignore PodSecurityPolicies in Kubernetes >= 1.25 Dec 24, 2022
@mrhein
Copy link

mrhein commented Jan 12, 2023

LGTM

@derailed could you bundle a new release?

@jon4hz
Copy link
Author

jon4hz commented Jan 12, 2023

Not sure why the test fails. I didn't make any changes to go.mod. Should I run go mod tidy to see if there are any changes?
Even though, it isn't really related to the PR.

@derailed
Copy link
Owner

@jon4hz Do the tests pass locally for you? I think deps changed and hence go mod tidy should fix this issue. If not I'll take another look. Tx!!

@jon4hz
Copy link
Author

jon4hz commented Jan 12, 2023

It is a bit weird. The tests are all passing locally and go mod tidy doesn't trigger any change. However I noticed, that the test pipeline is still using go 1.16. Bumping this to go 1.18 might fix the issue.

@deric
Copy link

deric commented Jan 18, 2023

@derailed Any progress on this?

@diego95root
Copy link

It'd be great if this could be merged :)

@muhlba91
Copy link

is there any progress?
we upgraded a few weeks ago and this blocks us to enable all automated scans we had in place before 1.25.

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jon4hz Awesome! Thank you for this!
Could you rebase your branch from master to resolve the conflicts?

@derailed
Copy link
Owner

Closing - Issue addressed in v0.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking Kubernetes 1.25 clusters fails due to PodSecurityPolicy
6 participants