Stale song-change notifications

[derat]

Old song-change notifications sometimes don't get cleared. One cause might be closing or reloading the page while the notification is displayed.

[derat]

I think I've seen this other times without reloading the page.

[derat]

I think that this still happens occasionally, but I'm not sure of the cause. It might be a Chrome OS bug where notifications aren't getting closed while the screen is locked.

[derat]

This still happens all the time. It's unrelated to screen-locking. I should investigate whether it happens when I foreground the tab while the notification is being shown.

[derat]

I'm seeing this happen even when the tab has been in the background the whole time.

Current best theory: Sometimes notifications seem to take a while to show up (I have no idea why). Maybe the delay is sometimes longer than the 3-second timeout to close the notification. The code in music-player.js looks reasonable to me, but maybe Chrome has a bug where close() doesn't work if the notification hasn't been shown yet:

      this.notification_ = new Notification(
        `${song.artist}\n${song.title}`,
        options
      );
      this.closeNotificationTimeoutId_ = window.setTimeout(() => {
        this.closeNotificationTimeoutId_ = null;
        this.closeNotification_();
      }, this.constructor.NOTIFICATION_SEC_ * 1000);

[derat]

Just saw a notification show up a full minute after a song had started playing (and then not get closed automatically). My best guess now is that Chrome is waiting for the notification's image to be downloaded before displaying anything.