Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are not available #1

Closed
lackac opened this issue Jun 11, 2012 · 0 comments
Closed

Icons are not available #1

lackac opened this issue Jun 11, 2012 · 0 comments

Comments

@lackac
Copy link

lackac commented Jun 11, 2012

There are two problems which prevent icons from being displayed:

  1. Twitter Bootstrap uses relative paths for the icon sprites by default
  2. the icons will not be in the public path of the application

I haven't tried yet, but I think #1 is easily solvable by adding second style which overrides the default @iconSpritePath and @iconWhiteSpritePath values.
#2 is trickier. Derby could add support for exposing static files in components. This could be configured similarly to the current styles configuration. However, I don't see an easy way to make these files accessible through the router.

An easier solution would be to add an optional configuration to derby-ui-boot, say linkImages which should be set by the application to its public path. If the decorator sees this option it will symlink the image files into the public directory and set the icon path variables accordingly.

I'm happy to help with implementing this. Which one should I implement? Do you see any other approach?

@nateps nateps closed this as completed Feb 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants