Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derby misinterprets closing tag / as part of the attribute a.k.a Derby doesn't preserve closing '/' of a self closed node. #173

Closed
juzerali opened this issue Nov 26, 2012 · 5 comments

Comments

@juzerali
Copy link

I have got a video at /public/uploads/1/video.mp4

model.get('_model.video') //=> /uploads/1/video.mp4

View

{#if _model.video}
    <video controls="controls" width="640" height="480">
      <source src={{_model.video}}/>
      Your browser does not support HTML5
    </video>
  {/} 

What is rendered:

<video controls="controls" width="640" height="480">
    <source id="$c" src="/uploads/video.mp4/">
    Your browser does not support HTML5
</video>

The '/' that is supposed to end the source tag is actually appended to url.

Workaround

Instead of <source src={{_model.video}}/>doing <source src={{_model.video}}></source> works fine.

@lefnire
Copy link
Contributor

lefnire commented Nov 26, 2012

surround it in quotes? <source src="{{_model.video}}"/>

@juzerali
Copy link
Author

I tried that. It wipes out / completely. Results in an unclosed DOM node. See the failng test in upcoming pull request.

@switz
Copy link

switz commented Nov 26, 2012

Did you try just removing the trailing slash on the source element? It still validates as HTML5 - http://d.saew.it/jXaD

On Monday, November 26, 2012 at 2:26 PM, Juzer Ali wrote:

I tried that. It wipes out / completely. Results in an unclosed DOM node. See the failng test in upcoming pull request.


Reply to this email directly or view it on GitHub (#173 (comment)).

@switz
Copy link

switz commented Nov 26, 2012

Oh sorry, missed the "workaround".

On Monday, November 26, 2012 at 2:26 PM, Juzer Ali wrote:

I tried that. It wipes out / completely. Results in an unclosed DOM node. See the failng test in upcoming pull request.


Reply to this email directly or view it on GitHub (#173 (comment)).

@juzerali
Copy link
Author

Can this be termed as a bug? I am currently trying to fix it by changing derbyjs source code.

@nateps nateps closed this as completed Jun 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants