Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup data.splits #100

Closed
wants to merge 1 commit into from
Closed

Cleanup data.splits #100

wants to merge 1 commit into from

Conversation

SLaks
Copy link
Contributor

@SLaks SLaks commented Mar 13, 2013

I handled the model cleanup event to empty the splits cache.

This fixes #72.

@lefnire
Copy link

lefnire commented Mar 13, 2013

Holy crap! I'm gonna test this on Habit today, this may be the holy grail!

@SLaks
Copy link
Contributor Author

SLaks commented Mar 13, 2013

This alone will not solve server memory leaks.

Leaking models will consume far more memory than only data.splits;you should really try to remove the leak entirely.

Also, this will only do anything when those models emit a cleanup event, which by default only happens every 128 event handler registrations.

@lefnire
Copy link

lefnire commented Mar 13, 2013

I see. I thought the leaky model was only a result of data.splits build up, I got ahead of myself :)

@SLaks
Copy link
Contributor Author

SLaks commented Mar 13, 2013

data.splits is a big (in memory consumption) part of a model, but the rest of the model (the actual data, the query descriptors, etc) is even bigger.

@SLaks
Copy link
Contributor Author

SLaks commented Mar 24, 2013

This was removed by 920784f

@SLaks SLaks closed this Mar 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data.splits in treeLookup leaks memory
2 participants