metadata.json dependencies leads to errors on the commandline

[stefanlasiewski]

This module is returning errors for our puppet module commands, running Puppet 3.8.2 , even through the files are there:

$ puppet module list >/dev/null
Warning: Missing dependency 'puppetlabs-concat':
  'derdanne-nfs' (v0.0.7) requires 'puppetlabs-concat' (>= 1.1.2)
Warning: Missing dependency 'puppetlabs-stdlib':
  'derdanne-nfs' (v0.0.7) requires 'puppetlabs-stdlib' (>= 4.5.0)

$ puppet module list
??? puppetlabs-concat (v1.2.3)
??? puppetlabs-inifile (v1.4.2)
??? puppetlabs-stdlib (v4.10.0)
$

If I modify nfs/metadata.json and and replace the hyphens with slashes, the error goes away:

Old:

  "dependencies": [
    {"name":"puppetlabs-stdlib","version_requirement":">= 4.5.0"},
    {"name":"puppetlabs-concat","version_requirement":">= 1.1.2"}
  ]   

New:

  "dependencies": [
    {"name":"puppetlabs/stdlib","version_requirement":">= 4.5.0"},
    {"name":"puppetlabs/concat","version_requirement":">= 1.1.2"}
  ]

$ puppet module list >/dev/null
# Nothing here. All is good.
$

The example at https://docs.puppetlabs.com/puppet/latest/reference/modules_metadata.html#specifying-dependencies uses slash characters and not hyphens. I believe that slash characters are preferred, but I'm not 100% positive.

[derdanne]

I will make the changes in the next version, thanks!