syslog #23
syslog #23
Conversation
brandonbloom
force-pushed
the
syslog
branch
5 times, most recently
from
8c9e922
to
9a878ae
Compare
| Store: store, | ||
| VarDir: paths.VarDir, | ||
| Store: store, | ||
| SyslogAddr: "localhost:4500", // XXX Configurable? |
There was a problem hiding this comment.
We probably should make this configurable. It looks like 4500 is commonly used for IPSec NAT traversal, so this might break some VPNs.
There was a problem hiding this comment.
Yeah, I didn't check if this port was available. I'm not quite sure what the right thing to do here is. I actually think maybe we should pick a port at random and write it in the run state / config file thing. What do you think?
There was a problem hiding this comment.
I think that is the right default behaviour, but it would still be nice to let users specify a specific port if they want to for whatever reason. This is another place where I think that it would be useful for exo to own the definition for the LogProvider. That way, there is one source of truth for the proxy to discover where to send logs.
|
|
||
| "github.com/deref/exo/logd/api" | ||
| ) | ||
|
|
||
| type Store interface { | ||
| // Returns the next log after the given argument. |
There was a problem hiding this comment.
It would be helpful to define what "next" means in this context. My immediate question is whether this would iterate through all logs available (regardless of what log I passed in first), or would or follow some natural ordering, potentially terminating without iterating all logs if I did not start at the "beginning".
There was a problem hiding this comment.
Good point. I'll improve this comment.
| var nextName string | ||
| if err := sto.db.View(func(txn *badger.Txn) error { | ||
| opts := badger.DefaultIteratorOptions | ||
| opts.PrefetchSize = 1000 |
There was a problem hiding this comment.
This option is not used with PrefetchValues = false
There was a problem hiding this comment.
D'oh. OK. Will remove.
| it.Next() | ||
| if !it.ValidForPrefix(prefix) { | ||
| if it.Valid() { | ||
| nextName = string(it.Item().Key()) |
There was a problem hiding this comment.
Is this correct? If I'm reading this right, we are looking for a log with the same name as the key, but the key is `(log + <255>, id).
There was a problem hiding this comment.
D'oh, you're right, this makes no sense at all. Will fix.
| it := txn.NewIterator(opts) | ||
| defer it.Close() | ||
|
|
||
| // TODO: Something better than a linear key scan. |
There was a problem hiding this comment.
Did somebody say secondary indexes? ;)
| @@ -0,0 +1,169 @@ | |||
| package logio | |||
There was a problem hiding this comment.
Instead of naming this logio, I think that we should go ahead and name it something more generic, since this is the component that will supervise processes. Maybe we should use something that conveys the idea of "supervisor", "proxy" or "wrapper" - foreman? bigbrother? cocoon? chrysalis? saran 😆?
There was a problem hiding this comment.
Yeah, definitely needs a better name. I was thinking about just calling it supervise. That work?
switch to syslog instead of log collector workers reading fifos