Change port numbers #430
Merged
Change port numbers #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonbloom
approved these changes
Oct 20, 2021
| @@ -1 +1,2 @@ | |||
| VITE_API_PORT=4000 | |||
| # FIXME: this should come from the config.toml | |||
There was a problem hiding this comment.
Is this file actually used at all? Seems like this is only relevant if vite is used with server-side rendering otherwise has a server attached, Since we distribute as 100% static build output, I think we can probably delete this file.
There was a problem hiding this comment.
Yes, it's definitely used in the build process, as specified here: https://vitejs.dev/guide/env-and-mode.html#env-files
I confirmed this by changing the value in the file and then grepping for that value in the outputted build:
❯ grep -o -R 'parseInt("ben-port-test")' ./gui/dist
./gui/dist/assets/index.cf1cf057.js:parseInt("ben-port-test")
| @@ -213,6 +213,21 @@ func RunServer(ctx context.Context, flags map[string]string) { | |||
| Next: mux, | |||
| }) | |||
|
|
|||
| go func() { | |||
There was a problem hiding this comment.
I think this is OK because when main returns all background goroutines are silently killed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.