New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPA implementation with documentation, test and training script #113
base: master
Are you sure you want to change the base?
Conversation
Oh ok! I'll leave this open for now. I will be forking nfldb this year before the season and getting that up-to-date w/ py3 etc etc. At that point i'll ask you to re-submit this to said fork. |
Oh boy, I fixed some bugs and now we have conflicts. May wanna hold off on this until the code stabilizes a bit. I have some plans brewing on adding nfldb so there will likely be a loooot more breaking changes coming. Stay tuned! Thanks for your submission. |
I only edit the game.py and live and schedule one are due to the change on schedule update over the new season. In game.py EPA is added as a property and it should be safe to merge |
I understand. The problem is i'm looking at updating nfldb and restructuring these projects. It's likely that this PR belongs in NFLDB. I am planning on simplifying this project a bit and making it entirely about pulling / organizing data. I am unsure if extrapolating/deducing data like EPA should belong here, there or maybe even in some kind of plugin. |
A plugin sounds like a good idea, maybe a test/simulate/project type for those NFL Analytics nerds that are ruining football. |
Closed #49 since origin repo is deleted.
For simple explanation of expected point added (EPA): https://www.espn.com/nfl/story/_/id/8379024/nfl-explaining-expected-points-metric
The PR has
training script named EPA_model.py which ultilize NFLdb and not intended to run here, but just for possible future enhancement/reproduction of model, and expected point for each down produced by the model
Updated game.py which contains script to parse play-by-play data and calculate expected point added
A small test
Feel free to ask for more detail on EPA model