Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include tests in release source tarball #46

Merged
merged 1 commit into from Mar 21, 2016
Merged

include tests in release source tarball #46

merged 1 commit into from Mar 21, 2016

Conversation

EdwardBetts
Copy link
Contributor

It is useful for end users to have tests to ensure the package is working correctly.

I've been working on building a package of this software to include in Debian GNU/Linux. During the package build process it is very helpful to be able to run the tests.

I also plan to run the tests frequently using the Debian continuous integration infrastructure. This will help to catch any regressions across the Python ecosystem within Debian.

Other distributions will find the tests useful for the same reason.

It is useful for end users to have tests to ensure the package is working correctly.

I've been working on building a package of this software to include in Debian GNU/Linux. During the package build process it is very helpful to be able to run the tests.

I also plan to run the tests frequently using the Debian continuous integration infrastructure. This will help to catch any regressions across the Python ecosystem within Debian.

Other distributions will find the tests useful for the same reason.
@derek73
Copy link
Owner

derek73 commented Mar 21, 2016

Thanks. You rock! Now I don't have to figure out how to do that.

The tests currently have some external requirements. They are in dev-requirements.txt, but that may actually include more than what is needed for tests. Do you know what I should do with those requirements?

@derek73 derek73 added this to the v0.3.15 milestone Mar 21, 2016
@EdwardBetts
Copy link
Contributor Author

I think it is fine just to include the tests, your build process doesn't need to run them and you don't need to modify your dev-requirements.

Somebody wanting to run the tests can either install everything from dev-requirements.txt or can try running the tests, see which imports are missing and install them. Or you could make a separate test-requirements.txt

The Debian package has its own list of Build-Depends, they are: python-dill, python-nose and python-setuptools (these are Debian package names). These are the packages required to build the package and run the test suite.

Does this make sense?

@derek73
Copy link
Owner

derek73 commented Mar 21, 2016

Ok, thanks for the info, yes that makes sense. Looking more closely I think that dill is the only thing in the requirements that's actually used in the tests. Great to know that's included in debian build tools.

derek73 added a commit that referenced this pull request Mar 21, 2016
include tests in release source tarball
@derek73 derek73 merged commit 8d88ce1 into derek73:master Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants