Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dynamic Supervisor Init typespec - Issue #181 #189

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Fix Dynamic Supervisor Init typespec - Issue #181 #189

merged 1 commit into from
Dec 23, 2019

Conversation

scudelletti
Copy link
Contributor

Hello! 👋

This PR fixes issue #181.

Currently horde has a few typespecs errors and one of them is in the init function inside the Horde.DynamicSupervisor.

This fix reduces the total amount of typespec errors from 10 to 6.
To see the errors I suggest you to run dialyzer in the test environment(MIX_ENV=test mix dialyzer) since the tests contain code that uses the library giving more context to dialyzer.

Thanks for you time and thank you very much for maintaining Horde! It's an awesome library! 🎉

@derekkraan derekkraan merged commit e6312e2 into derekkraan:master Dec 23, 2019
@derekkraan
Copy link
Owner

Thanks for the PR. I have simplified the spec to {:ok, options()} | :ignore. I'm not sure what dialyzer meant by adding all those other extra things to the callback, but this also seems to satisfy dialyzer.

@scudelletti scudelletti deleted the ds-fix-typespec-for-init branch December 30, 2019 08:14
@anthonator
Copy link
Contributor

Would it be possible to get a patch release of this?

@KamilZielinski
Copy link

@anthonator No patch so far but there's 0.8.0-rc.1 which seems to contain these changes. You may want to try it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants